enchanting table gives (only) armor the same primary enchantment over and over again #20

Open
opened 2025-12-26 20:16:50 +00:00 by remyn0 · 6 comments

Playing on fabric 1.21.1, when enchanting, the enchanting table seems to assign armor items the same primary enchantment over and over again, while tools are able to get different primary enchantments.

list of installed mods (performance only):
AsyncParticles-3.4.0-beta.1+1.21.1.jar
BadOptimizations-2.3.1-1.21.1.jar
c2me-fabric-mc1.21.1-0.3.0+alpha.0.362.jar
cloth-config-15.0.140-fabric.jar
ConfigManager-fabric-1.21.x-1.1.0.jar
dynamic-fps-3.9.5+minecraft-1.21.0-fabric.jar
enchiridion-fabric-0.1.8+1.21.1.jar
enhancedblockentities-0.10.2+1.21.jar
entityculling-fabric-1.9.3-mc1.21.1.jar
fabric-api-0.116.7+1.21.1.jar
ferritecore-7.0.2-hotfix-fabric.jar
ImmediatelyFast-Fabric-1.6.7+1.21.1.jar
Ixeris-3.6.2+1.21.1-fabric.jar
lithium-fabric-0.15.0+mc1.21.1.jar
modernfix-fabric-5.25.1+mc1.21.1.jar
modmenu-11.0.3.jar
moreculling-fabric-1.21.1-1.0.6.jar
sodium-fabric-0.6.13+mc1.21.1.jar
threadtweak-fabric-0.1.5+mc1.21.1.jar

Playing on fabric 1.21.1, when enchanting, the enchanting table seems to assign armor items the same primary enchantment over and over again, while tools are able to get different primary enchantments. list of installed mods (performance only): AsyncParticles-3.4.0-beta.1+1.21.1.jar BadOptimizations-2.3.1-1.21.1.jar c2me-fabric-mc1.21.1-0.3.0+alpha.0.362.jar cloth-config-15.0.140-fabric.jar ConfigManager-fabric-1.21.x-1.1.0.jar dynamic-fps-3.9.5+minecraft-1.21.0-fabric.jar enchiridion-fabric-0.1.8+1.21.1.jar enhancedblockentities-0.10.2+1.21.jar entityculling-fabric-1.9.3-mc1.21.1.jar fabric-api-0.116.7+1.21.1.jar ferritecore-7.0.2-hotfix-fabric.jar ImmediatelyFast-Fabric-1.6.7+1.21.1.jar Ixeris-3.6.2+1.21.1-fabric.jar lithium-fabric-0.15.0+mc1.21.1.jar modernfix-fabric-5.25.1+mc1.21.1.jar modmenu-11.0.3.jar moreculling-fabric-1.21.1-1.0.6.jar sodium-fabric-0.6.13+mc1.21.1.jar threadtweak-fabric-0.1.5+mc1.21.1.jar
Author

for example using a custom, replace: true, in_enchanting_table.json in data\minecraft\tags\enchantment with only vaulting enabled, results in the enchanting table having valid enchantments for leggins:

{
"replace": true,
"values": [
"enchiridion:vaulting"
]
}

however if you edit it to be:

{
"replace": true,
"values": [
"enchiridion:circuit"
]
}
and try to enchant leggins in the table, the enchanting table doesnt even come up with any possible enchantments to give to the leggins.

for example using a custom, replace: true, in_enchanting_table.json in data\minecraft\tags\enchantment with only vaulting enabled, results in the enchanting table having valid enchantments for leggins: { "replace": true, "values": [ "enchiridion:vaulting" ] } however if you edit it to be: { "replace": true, "values": [ "enchiridion:circuit" ] } and try to enchant leggins in the table, the enchanting table doesnt even come up with any possible enchantments to give to the leggins.
Owner

@remyn0 wrote in #20 (comment):

for example using a custom, replace: true, in_enchanting_table.json in data\minecraft\tags\enchantment with only vaulting enabled, results in the enchanting table having valid enchantments for leggins:

{ "replace": true, "values": [ "enchiridion:vaulting" ] }

however if you edit it to be:

{ "replace": true, "values": [ "enchiridion:circuit" ] } and try to enchant leggins in the table, the enchanting table doesnt even come up with any possible enchantments to give to the leggins.

Please do not use "replace": true outside of testing. This will remove every enchantment from the collection other than the ones you specify.

I think this could be an issue with Circuit for some reason, zero clue what could be going on here.

@remyn0 wrote in https://git.greenhouse.lgbt/Modding/enchiridion/issues/20#issuecomment-319: > for example using a custom, replace: true, in_enchanting_table.json in data\minecraft\tags\enchantment with only vaulting enabled, results in the enchanting table having valid enchantments for leggins: > > { "replace": true, "values": [ "enchiridion:vaulting" ] } > > however if you edit it to be: > > { "replace": true, "values": [ "enchiridion:circuit" ] } and try to enchant leggins in the table, the enchanting table doesnt even come up with any possible enchantments to give to the leggins. Please do not use `"replace": true` outside of testing. This will remove every enchantment from the collection other than the ones you specify. I think this could be an issue with Circuit for some reason, zero clue what could be going on here.
Owner

I am going to investigate what's exactly going on here at some point.

The issue with Chestplates is that Thorns is its only enchantment atm. Leggings should have Circuit or Vaulting, and Boots only have Depth Strider bc I haven't made Sticky not treasure yet.

Sticky will become non-treasure in the next update. So it'll be added to the pool.

I am going to investigate what's exactly going on here at some point. The issue with Chestplates is that Thorns is its only enchantment atm. Leggings should have Circuit or Vaulting, and Boots only have Depth Strider bc I haven't made Sticky not treasure yet. Sticky will become non-treasure in the next update. So it'll be added to the pool.
Owner

Helmets have no Primaries atm.

Helmets have no Primaries atm.
Owner

The mod is still largely incomplete, so some items will just have only one primary atm.

I would suggest:

  1. Wait for updates that add more enchantments.
  2. Install more mods that add enchantments, and categorize them via tags.
  3. Make your own enchantments. Enchantments are data driven after all!
The mod is still largely incomplete, so some items will just have only one primary atm. I would suggest: 1. Wait for updates that add more enchantments. 2. Install more mods that add enchantments, and categorize them via tags. 3. Make your own enchantments. Enchantments are data driven after all!
Owner

I can't for certain say whether 1.21.1 will get the next update, as its up to me or somebody else to backport it. It probably won't get updated after the next content update if it even does tho.

Im aiming for 26.1.x for 0.2.0, mainly bc maintaining 1.21.1 is a bit of a chore for me.

I can't for certain say whether 1.21.1 will get the next update, as its up to me or somebody else to backport it. It probably won't get updated after the next content update if it even does tho. Im aiming for 26.1.x for 0.2.0, mainly bc maintaining 1.21.1 is a bit of a chore for me.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Modding/enchiridion#20
No description provided.