Prevent locked shape keys from translating #260

Merged
Ghost merged 7 commits from refs/pull/260/head into blender-44-dev 2025-01-06 11:26:29 +00:00
Ghost commented 2025-01-05 15:51:56 +00:00 (Migrated from git.disroot.org)

Locking shape keys should prevent them from being translated. This is useful for mmd shape keys and the likes.

Locking shape keys should prevent them from being translated. This is useful for mmd shape keys and the likes.
Ghost commented 2025-01-05 16:31:42 +00:00 (Migrated from git.disroot.org)

Hi there,

This would be a useful feature for certain situations. However, since this is a manual button that users intentionally press to translate their shapekeys, many expect it to translate all shapekeys whether locked or not - as this has been the standard behavior for years.

A better implementation would be to add an option under the translation buttons or in settings where users can choose whether to respect locked shapekeys during translation.

I'll be happy to merge this once the change is implemented as a user option rather than a forced behavior, I may do this myself later if you haven't done it.

Thanks

Hi there, This would be a useful feature for certain situations. However, since this is a manual button that users intentionally press to translate their shapekeys, many expect it to translate all shapekeys whether locked or not - as this has been the standard behavior for years. A better implementation would be to add an option under the translation buttons or in settings where users can choose whether to respect locked shapekeys during translation. I'll be happy to merge this once the change is implemented as a user option rather than a forced behavior, I may do this myself later if you haven't done it. Thanks
Ghost commented 2025-01-05 17:03:21 +00:00 (Migrated from git.disroot.org)

Makes sense, I'll look into adding that.

Makes sense, I'll look into adding that.
Ghost commented 2025-01-05 17:05:03 +00:00 (Migrated from git.disroot.org)

Awesome!

Awesome!
Ghost commented 2025-01-05 21:29:13 +00:00 (Migrated from git.disroot.org)

Done. Not sure about the wording for the labels but I put the checkbox (disabled by default) under the google one.
image

Done. Not sure about the wording for the labels but I put the checkbox (disabled by default) under the google one. ![image](https://github.com/user-attachments/assets/db282707-07fa-478b-95c0-aeba723f4e27)
Ghost commented 2025-01-05 21:37:58 +00:00 (Migrated from git.disroot.org)

The code looks good to me. I'll test it tomorrow as I about to head to bed. As long as everything is fine, I'll merge it and backport to Blender 4.3 and 4.2. I planning to release the next stable release next week as well so this will make it into that release :).

The code looks good to me. I'll test it tomorrow as I about to head to bed. As long as everything is fine, I'll merge it and backport to Blender 4.3 and 4.2. I planning to release the next stable release next week as well so this will make it into that release :).
Ghost commented 2025-01-05 21:43:58 +00:00 (Migrated from git.disroot.org)

Cool, thanks!

I'm sure some people will find this useful.

Didn't notice it was for the unreleased version of blender, so the back port is appreciated 😌


From: Yusarina @.>
Sent: Sunday, January 5, 2025 11:38:19 PM
To: teamneoneko/Cats-Blender-Plugin-Unofficial- @.
>
Cc: rurre @.>; Author @.>
Subject: Re: [teamneoneko/Cats-Blender-Plugin-Unofficial-] Prevent locked shape keys from translating (PR #260)

The code looks good to me. I'll test it tomorrow as I about to head to bed. As long as everything is fine, I'll merge it and backport to Blender 4.3 and 4.2. I planning to release the next stable release next week as well so this will make it into that release :).


Reply to this email directly, view it on GitHubhttps://github.com/teamneoneko/Cats-Blender-Plugin-Unofficial-/pull/260#issuecomment-2571758695, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD7RGWN7JQGOJZWE5O4SKAT2JGQ4XAVCNFSM6AAAAABUUHVDRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRG42TQNRZGU.
You are receiving this because you authored the thread.Message ID: @.***>

Cool, thanks! I'm sure some people will find this useful. Didn't notice it was for the unreleased version of blender, so the back port is appreciated 😌 ________________________________ From: Yusarina ***@***.***> Sent: Sunday, January 5, 2025 11:38:19 PM To: teamneoneko/Cats-Blender-Plugin-Unofficial- ***@***.***> Cc: rurre ***@***.***>; Author ***@***.***> Subject: Re: [teamneoneko/Cats-Blender-Plugin-Unofficial-] Prevent locked shape keys from translating (PR #260) The code looks good to me. I'll test it tomorrow as I about to head to bed. As long as everything is fine, I'll merge it and backport to Blender 4.3 and 4.2. I planning to release the next stable release next week as well so this will make it into that release :). — Reply to this email directly, view it on GitHub<https://github.com/teamneoneko/Cats-Blender-Plugin-Unofficial-/pull/260#issuecomment-2571758695>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7RGWN7JQGOJZWE5O4SKAT2JGQ4XAVCNFSM6AAAAABUUHVDRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRG42TQNRZGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>
Ghost commented 2025-01-06 11:26:25 +00:00 (Migrated from git.disroot.org)

This tested fine, now merged, will be backported either today or tomorrow.

This tested fine, now merged, will be backported either today or tomorrow.
Ghost (Migrated from git.disroot.org) reviewed 2025-01-06 11:27:25 +00:00
Ghost (Migrated from git.disroot.org) left a comment

This is fine

This is fine
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Kneelawk/Cats-Blender-Plugin!260
No description provided.