Modding/silicate
Modding/silicate
5
0
Fork 1
Code Issues 4 Pull requests 1 Projects Releases 19 Packages Wiki Activity Actions

WIP: Port 1.0 to 1.21.11 #22

Closed
cassian wants to merge 0 commits from cassian/silicate:port/1.21.11 into feat/1.0
pull from: cassian/silicate:port/1.21.11
merge into: Modding:feat/1.0
Conversation 4 Commits - Files changed -
cassian commented 2026-03-11 01:33:08 +00:00
Contributor
Copy link

build doesn't seem to run tests correctly, but gametests work.

`build` doesn't seem to run tests correctly, but gametests work.
🚀 1
Sylv reviewed 2026-03-11 19:47:07 +00:00
xplat/src/test/java/lgbt/greenhouse/silicate/test/instance/PredicatesTestInstance.java
@ -17,3 +17,1 @@
import net.minecraft.world.entity.animal.horse.SkeletonHorse;
import net.minecraft.world.entity.monster.Skeleton;
import net.minecraft.world.entity.projectile.Arrow;
import net.minecraft.world.entity.animal.equine.SkeletonHorse;
Sylv commented 2026-03-11 19:47:07 +00:00
Owner
Copy link

equine? Is Mojang going to make an horse update?

*equine*? Is Mojang going to make an horse update?
cassian commented 2026-03-11 20:24:16 +00:00
Author
Contributor
Copy link

Just a package name improvement considering that folder contains Llamas and Camels.

Just a package name improvement considering that folder contains Llamas and Camels.
👍 1
Sylv marked this conversation as resolved
Sylv reviewed 2026-03-11 19:47:44 +00:00
Sylv left a comment
Owner
Copy link

Looks good to me so far. I'll have to investigate the build issue though.

Is there any reason it's Draft?

Looks good to me so far. I'll have to investigate the `build` issue though. Is there any reason it's Draft?
Sylv added this to the 1.0 milestone 2026-03-11 20:10:05 +00:00
cassian commented 2026-03-11 20:24:52 +00:00
Author
Contributor
Copy link

Just the build issue, I didn't want to it to be merged before the tests were fixed since you said it was a priority.

Just the build issue, I didn't want to it to be merged before the tests were fixed since you said it was a priority.
Sylv commented 2026-03-11 20:32:10 +00:00
Owner
Copy link

Ah, yes. Tests are important for Silicate since they ensure we don't regress or reintroduce bugs.

Ah, yes. Tests are important for Silicate since they ensure we don't regress or reintroduce bugs.
Sylv closed this pull request 2026-03-31 02:00:53 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Compat
Breaking
Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Port

Port to another platform version

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Security

This is security issue

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
Needs Triage
This issue or pull request needs to be triaged

  
Testing

Issue or pull request related to testing

No labels
Compat
Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Port
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Security
Status
Abandoned
Status
Blocked
Status
Need More Info
Status
Needs Triage
Testing
Milestone
Clear milestone
No items
No milestone
1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Modding/silicate!22
No description provided.